Xuanwo commented on PR #503: URL: https://github.com/apache/iceberg-rust/pull/503#issuecomment-2267076323
> I recommend you accept each of these suggestions blindly (just click on the `Commit suggestion` button next to each one). > These suggestions add ~1500 lines of code defining 59 tests that cover all the behaviours I would expect from a correctly functioning `Catalog` implementation. Hi @fqaiser94, do you think it would be a good idea to create a new crate named `catalog_integration_tests` for those tests, so that all catalogs can use them? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
