fqaiser94 commented on PR #503: URL: https://github.com/apache/iceberg-rust/pull/503#issuecomment-2267084086
> Hi @fqaiser94, do you think it would be a good idea to create a new crate named `catalog_integration_tests` for those tests, so that all catalogs can use them? I imagine that each catalog only needs to be created once and then passed into `test_catalog()`. @Xuanwo Ha, yea I was thinking of something similar but I definitely don't want to overload this PR with too many concerns. Let's see how things go in this PR first and if it still makes sense, I can potentially follow-up with another PR to consolidate catalog testing where it makes sense. The main concern I have is that the existing catalogs don't all follow exactly the same behaviour, there are small, subtle differences in behaviour like checking for tables before dropping a namespace, error messaging, etc. It may or may not be worth aligning behaviours but we can discuss all of that when we get there. Eh I might start working on this in in parallel, time permitting. Created a ticket for it here: https://github.com/apache/iceberg-rust/issues/519 Let's continue any further discussion there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
