github-actions[bot] closed pull request #11829: Remove unneeded metadata read
during update event generation
URL: https://github.com/apache/iceberg/pull/11829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
github-actions[bot] commented on PR #11829:
URL: https://github.com/apache/iceberg/pull/11829#issuecomment-2673005709
This pull request has been closed due to lack of activity. This is not a
judgement on the merit of the PR in any way. It is just a way of keeping the PR
queue manageable. If
github-actions[bot] commented on PR #11829:
URL: https://github.com/apache/iceberg/pull/11829#issuecomment-2655136284
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pul
grantatspothero commented on code in PR #11829:
URL: https://github.com/apache/iceberg/pull/11829#discussion_r1904696125
##
core/src/test/java/org/apache/iceberg/TestTables.java:
##
@@ -255,8 +257,13 @@ void failCommits(int numFailures) {
this.failCommits = numFailures;
grantatspothero commented on code in PR #11829:
URL: https://github.com/apache/iceberg/pull/11829#discussion_r1904687147
##
core/src/test/java/org/apache/iceberg/TestTables.java:
##
@@ -255,8 +257,13 @@ void failCommits(int numFailures) {
this.failCommits = numFailures;
grantatspothero commented on code in PR #11829:
URL: https://github.com/apache/iceberg/pull/11829#discussion_r1904687147
##
core/src/test/java/org/apache/iceberg/TestTables.java:
##
@@ -255,8 +257,13 @@ void failCommits(int numFailures) {
this.failCommits = numFailures;
grantatspothero commented on code in PR #11829:
URL: https://github.com/apache/iceberg/pull/11829#discussion_r1904580753
##
core/src/test/java/org/apache/iceberg/util/TestReachableFileUtil.java:
##
@@ -114,7 +114,10 @@ public void testMetadataFileLocationsWithMissingFiles() {
grantatspothero commented on code in PR #11829:
URL: https://github.com/apache/iceberg/pull/11829#discussion_r1893174793
##
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##
@@ -475,10 +475,14 @@ public void commit() {
}
}
+ Object updateEvent(Snapshot c
grantatspothero commented on code in PR #11829:
URL: https://github.com/apache/iceberg/pull/11829#discussion_r1902204257
##
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##
@@ -475,10 +475,14 @@ public void commit() {
}
}
+ Object updateEvent(Snapshot c
amogh-jahagirdar commented on code in PR #11829:
URL: https://github.com/apache/iceberg/pull/11829#discussion_r1900307975
##
core/src/main/java/org/apache/iceberg/FastAppend.java:
##
@@ -157,12 +158,16 @@ public List apply(TableMetadata base,
Snapshot snapshot) {
}
@Ove
grantatspothero commented on code in PR #11829:
URL: https://github.com/apache/iceberg/pull/11829#discussion_r1893174793
##
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##
@@ -475,10 +475,14 @@ public void commit() {
}
}
+ Object updateEvent(Snapshot c
grantatspothero opened a new pull request, #11829:
URL: https://github.com/apache/iceberg/pull/11829
Followup from this PR:
https://github.com/apache/iceberg/pull/10523
The above PR removed unnecessary objectstore reads after commit, but there
was 1 I missed. `SnapshotProducer.noti
12 matches
Mail list logo
