grantatspothero commented on code in PR #11829:
URL: https://github.com/apache/iceberg/pull/11829#discussion_r1904580753
##########
core/src/test/java/org/apache/iceberg/util/TestReachableFileUtil.java:
##########
@@ -114,7 +114,10 @@ public void testMetadataFileLocationsWithMissingFiles() {
// delete v3.metadata.json making v2.metadata.json and v1.metadata.json
inaccessible
table.io().deleteFile(location);
- Set<String> metadataFileLocations =
ReachableFileUtil.metadataFileLocations(table, true);
+ // original hadoop table will not see the file deletion
Review Comment:
This is side effect of removing `refresh()` calls during update event
generation. Code which relied upon table.refresh being called for correctness
will now break.
This is mostly a problem for hadoop/filesystem tables and these are
deprecated: https://iceberg.apache.org/spec/#file-system-tables
For metastore catalogs for example, `table.refresh()` can be manually called
after commits. This does not work for filesystem tables hence the creating of a
new table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
