grantatspothero commented on code in PR #11829: URL: https://github.com/apache/iceberg/pull/11829#discussion_r1902204257
########## core/src/main/java/org/apache/iceberg/SnapshotProducer.java: ########## @@ -475,10 +475,14 @@ public void commit() { } } + Object updateEvent(Snapshot committedSnapshot) { Review Comment: Was trying to provide context why I didn't modify: `PendingUpdate.updateEvent` directly (it is a public API) But agree with you is safe to modify SnapshotProducer here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org