Fokko commented on PR #1112:
URL: https://github.com/apache/iceberg-python/pull/1112#issuecomment-2331938676
@sungwy No problem at all, I've pulled in latest master 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
sungwy commented on PR #1112:
URL: https://github.com/apache/iceberg-python/pull/1112#issuecomment-2326240075
Hi @Fokko
Just a heads up - sorry for adding in a merge conflict here. I merged in
https://github.com/apache/iceberg-python/pull/820 first because it had been
open for quite
Fokko commented on code in PR #1112:
URL: https://github.com/apache/iceberg-python/pull/1112#discussion_r1739974152
##
pyiceberg/catalog/sql.py:
##
@@ -407,20 +412,18 @@ def _commit_table(self, table_request:
CommitTableRequest) -> CommitTableRespons
NoSuchTableErr
Fokko commented on code in PR #1112:
URL: https://github.com/apache/iceberg-python/pull/1112#discussion_r1739973689
##
pyiceberg/table/__init__.py:
##
@@ -1673,12 +1673,8 @@ def refs(self) -> Dict[str, SnapshotRef]:
return self.metadata.refs
def _do_commit(self,
Fokko commented on code in PR #1112:
URL: https://github.com/apache/iceberg-python/pull/1112#discussion_r1739973551
##
pyiceberg/catalog/rest.py:
##
@@ -773,6 +771,17 @@ def _commit_table(self, table_request: CommitTableRequest)
-> CommitTableRespons
)
ret
kevinjqliu commented on code in PR #1112:
URL: https://github.com/apache/iceberg-python/pull/1112#discussion_r1739511962
##
pyiceberg/table/__init__.py:
##
@@ -1673,12 +1673,8 @@ def refs(self) -> Dict[str, SnapshotRef]:
return self.metadata.refs
def _do_commit(s
Fokko commented on code in PR #1112:
URL: https://github.com/apache/iceberg-python/pull/1112#discussion_r1737194124
##
pyiceberg/catalog/rest.py:
##
@@ -734,9 +739,11 @@ def _commit_table(self, table_request: CommitTableRequest)
-> CommitTableRespons
CommitFailedEx
Fokko commented on code in PR #1112:
URL: https://github.com/apache/iceberg-python/pull/1112#discussion_r1737130122
##
pyiceberg/catalog/glue.py:
##
@@ -462,10 +468,8 @@ def _commit_table(self, table_request: CommitTableRequest)
-> CommitTableRespons
NoSuchTableErr
Fokko commented on code in PR #1112:
URL: https://github.com/apache/iceberg-python/pull/1112#discussion_r1737129443
##
pyiceberg/catalog/rest.py:
##
@@ -719,12 +721,15 @@ def
_remove_catalog_name_from_table_request_identifier(self, table_request: Comm
)
re
sungwy commented on code in PR #1112:
URL: https://github.com/apache/iceberg-python/pull/1112#discussion_r1736166915
##
pyiceberg/catalog/hive.py:
##
@@ -445,7 +449,9 @@ def _commit_table(self, table_request: CommitTableRequest)
-> CommitTableRespons
if loc
Fokko opened a new pull request, #1112:
URL: https://github.com/apache/iceberg-python/pull/1112
This was brought up earlier, and I think this is a good idea. I changed the
signature to also pass in the table.
--
This is an automated message from the Apache Git Service.
To respond to the m
11 matches
Mail list logo
