Fokko commented on code in PR #1112: URL: https://github.com/apache/iceberg-python/pull/1112#discussion_r1739973689
########## pyiceberg/table/__init__.py: ########## @@ -1673,12 +1673,8 @@ def refs(self) -> Dict[str, SnapshotRef]: return self.metadata.refs def _do_commit(self, updates: Tuple[TableUpdate, ...], requirements: Tuple[TableRequirement, ...]) -> None: - response = self.catalog._commit_table( # pylint: disable=W0212 - CommitTableRequest( - identifier=TableIdentifier(namespace=self._identifier[:-1], name=self._identifier[-1]), - updates=updates, - requirements=requirements, - ) + response = self.catalog.commit_table( # pylint: disable=W0212 Review Comment: Good one, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org