Fokko commented on code in PR #1112:
URL: https://github.com/apache/iceberg-python/pull/1112#discussion_r1737194124


##########
pyiceberg/catalog/rest.py:
##########
@@ -734,9 +739,11 @@ def _commit_table(self, table_request: CommitTableRequest) 
-> CommitTableRespons
             CommitFailedException: Requirement not met, or a conflict with a 
concurrent commit.
             CommitStateUnknownException: Failed due to an internal exception 
on the side of the catalog.
         """
+        identifier = TableIdentifier(namespace=table.identifier[1:-1], 
name=table.identifier[-1])

Review Comment:
   Thanks, yes, this was still work in progress 🙈 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to