Fokko commented on code in PR #1112:
URL: https://github.com/apache/iceberg-python/pull/1112#discussion_r1737130122
##########
pyiceberg/catalog/glue.py:
##########
@@ -462,10 +468,8 @@ def _commit_table(self, table_request: CommitTableRequest)
-> CommitTableRespons
NoSuchTableError: If a table with the given identifier does not
exist.
CommitFailedException: Requirement not met, or a conflict with a
concurrent commit.
"""
- identifier_tuple = self._identifier_to_tuple_without_catalog(
- tuple(table_request.identifier.namespace.root +
[table_request.identifier.name])
- )
- database_name, table_name =
self.identifier_to_database_and_table(identifier_tuple)
+ table_identifier =
self.identifier_to_tuple_without_catalog(table.identifier)
Review Comment:
Good catch, I've switched to the private method instead 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
