chil-pavn commented on PR #146:
URL: https://github.com/apache/iceberg-go/pull/146#issuecomment-2580874842
@jwtryg yes, i am intending to finish off rest catalog operations first as i
already have a draft for the same. Once it is done, i could extend to others
too.
@zeroshade sure, i
zeroshade commented on PR #146:
URL: https://github.com/apache/iceberg-go/pull/146#issuecomment-2578935791
Btw, since both of you are being active on here, I'd love it either of you
would be able and willing to give a look at the PRs I filed recently (#244 and
#245) for more catalog functio
jwtryg commented on PR #146:
URL: https://github.com/apache/iceberg-go/pull/146#issuecomment-2578710739
@zeroshade that's super :)
@chil-pavn I have only just started - so feel free to go ahead. Will you
only be working on the unit tests for the rest catalog operations, however?
--
chil-pavn commented on PR #146:
URL: https://github.com/apache/iceberg-go/pull/146#issuecomment-2578234507
Part of #63 . @jwtryg let me know if you are already working on the unit
tests so that we both don't end up doing the same.
--
This is an automated message from the Apache Git Servic
zeroshade merged PR #146:
URL: https://github.com/apache/iceberg-go/pull/146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
jwtryg commented on PR #146:
URL: https://github.com/apache/iceberg-go/pull/146#issuecomment-2572532941
> @jwtryg Is there anything else outstanding on this or is this ready for
review again?
@zeroshade I will look through all of your previous comments today to make
sure it is ready
zeroshade commented on PR #146:
URL: https://github.com/apache/iceberg-go/pull/146#issuecomment-2568286153
@jwtryg Is there anything else outstanding on this or is this ready for
review again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
jwtryg commented on code in PR #146:
URL: https://github.com/apache/iceberg-go/pull/146#discussion_r1890812959
##
table/metadata.go:
##
@@ -80,20 +92,544 @@ type Metadata interface {
SnapshotByName(name string) *Snapshot
// CurrentSnapshot returns the table's cur
jwtryg commented on code in PR #146:
URL: https://github.com/apache/iceberg-go/pull/146#discussion_r1890805188
##
table/metadata.go:
##
@@ -370,26 +928,34 @@ func (c *commonMetadata) validate() error {
func (c *commonMetadata) Version() int { return c.FormatVersion }
-type
zeroshade commented on code in PR #146:
URL: https://github.com/apache/iceberg-go/pull/146#discussion_r1882697400
##
table/metadata.go:
##
@@ -80,20 +92,544 @@ type Metadata interface {
SnapshotByName(name string) *Snapshot
// CurrentSnapshot returns the table's
zeroshade commented on PR #146:
URL: https://github.com/apache/iceberg-go/pull/146#issuecomment-2539733353
My apologies for the long delay here, could you resolve the conflicts? I
should be able to give this a new pass of review in the next day or so.
--
This is an automated message from
jwtryg commented on PR #146:
URL: https://github.com/apache/iceberg-go/pull/146#issuecomment-2440181205
@zeroshade thank you for your patience :)
I have implemented your feedback and made some other changes - specifically,
being more mindful of what should be exported, and then undoin
zeroshade commented on PR #146:
URL: https://github.com/apache/iceberg-go/pull/146#issuecomment-2429784559
@jwtryg any updates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
zeroshade commented on code in PR #146:
URL: https://github.com/apache/iceberg-go/pull/146#discussion_r1760197376
##
catalog/rest.go:
##
@@ -546,12 +640,8 @@ func (r *RestCatalog) ListTables(ctx context.Context,
namespace table.Identifier
path := []string{"namespaces",
jwtryg commented on code in PR #146:
URL: https://github.com/apache/iceberg-go/pull/146#discussion_r1754973597
##
table/metadata.go:
##
@@ -370,26 +876,26 @@ func (c *commonMetadata) validate() error {
func (c *commonMetadata) Version() int { return c.FormatVersion }
-type
jwtryg commented on code in PR #146:
URL: https://github.com/apache/iceberg-go/pull/146#discussion_r1754963661
##
table/metadata.go:
##
@@ -80,20 +86,512 @@ type Metadata interface {
SnapshotByName(name string) *Snapshot
// CurrentSnapshot returns the table's cur
jwtryg commented on code in PR #146:
URL: https://github.com/apache/iceberg-go/pull/146#discussion_r1754962455
##
table/metadata.go:
##
@@ -80,20 +86,512 @@ type Metadata interface {
SnapshotByName(name string) *Snapshot
// CurrentSnapshot returns the table's cur
jwtryg commented on code in PR #146:
URL: https://github.com/apache/iceberg-go/pull/146#discussion_r1754957335
##
table/metadata.go:
##
@@ -80,20 +86,512 @@ type Metadata interface {
SnapshotByName(name string) *Snapshot
// CurrentSnapshot returns the table's cur
jwtryg commented on code in PR #146:
URL: https://github.com/apache/iceberg-go/pull/146#discussion_r1754951127
##
table/metadata.go:
##
@@ -80,20 +86,512 @@ type Metadata interface {
SnapshotByName(name string) *Snapshot
// CurrentSnapshot returns the table's cur
jwtryg commented on code in PR #146:
URL: https://github.com/apache/iceberg-go/pull/146#discussion_r1754949535
##
partitions.go:
##
@@ -117,6 +117,10 @@ func (ps PartitionSpec) Equals(other PartitionSpec) bool {
return ps.id == other.id && slices.Equal(ps.fields, other.f
jwtryg commented on code in PR #146:
URL: https://github.com/apache/iceberg-go/pull/146#discussion_r1754883143
##
catalog/catalog.go:
##
@@ -146,9 +147,9 @@ type Catalog interface {
// identifiers containing the information required to load the table
via that catalog.
jwtryg commented on code in PR #146:
URL: https://github.com/apache/iceberg-go/pull/146#discussion_r1754878148
##
catalog/catalog.go:
##
@@ -146,9 +147,9 @@ type Catalog interface {
// identifiers containing the information required to load the table
via that catalog.
jwtryg opened a new pull request, #146:
URL: https://github.com/apache/iceberg-go/pull/146
Hi @zeroshade
I think it's really cool that you are working on a golang-iceberg
implementation, and I would like to contribute if I can.
I have tried to finish the rest catalog implementatio
23 matches
Mail list logo
