jwtryg commented on code in PR #146:
URL: https://github.com/apache/iceberg-go/pull/146#discussion_r1754883143
##########
catalog/catalog.go:
##########
@@ -146,9 +147,9 @@ type Catalog interface {
// identifiers containing the information required to load the table
via that catalog.
ListTables(ctx context.Context, namespace table.Identifier)
([]table.Identifier, error)
// LoadTable loads a table from the catalog and returns a Table with
the metadata.
- LoadTable(ctx context.Context, identifier table.Identifier, props
iceberg.Properties) (*table.Table, error)
+ LoadTable(ctx context.Context, identifier table.Identifier)
(*table.Table, error)
// DropTable tells the catalog to drop the table entirely
- DropTable(ctx context.Context, identifier table.Identifier) error
+ DropTable(ctx context.Context, identifier table.Identifier, purge bool)
error
Review Comment:
I took this field directly from the OpenAPI specification:
https://github.com/apache/iceberg/blob/34cd01ba2e057866cdb13db8f9919bc98e11e638/open-api/rest-catalog-open-api.yaml#L1096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
