jwtryg commented on code in PR #146:
URL: https://github.com/apache/iceberg-go/pull/146#discussion_r1754973597
##########
table/metadata.go:
##########
@@ -370,26 +876,26 @@ func (c *commonMetadata) validate() error {
func (c *commonMetadata) Version() int { return c.FormatVersion }
-type MetadataV1 struct {
- Schema iceberg.Schema `json:"schema"`
+type metadataV1 struct {
+ Schema *iceberg.Schema `json:"schema"`
Review Comment:
But the metadataV1 is now unexported, so this shoulod be relatively few
places. But yes, it does. However, if we assign schemas directly, vet will
throw an error as we are copiyng a lock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
