Re: [PR] Hive: Make HiveMetastoreExtension configurable [iceberg]

2023-12-13 Thread via GitHub
nastra commented on code in PR #9288: URL: https://github.com/apache/iceberg/pull/9288#discussion_r1425070360 ## hive-metastore/src/test/java/org/apache/iceberg/hive/HiveMetastoreExtension.java: ## @@ -80,4 +82,27 @@ public HiveConf hiveConf() { public TestHiveMetastore metas

Re: [PR] Hive: Make HiveMetastoreExtension configurable [iceberg]

2023-12-13 Thread via GitHub
Fokko commented on PR #9288: URL: https://github.com/apache/iceberg/pull/9288#issuecomment-1853486502 Thanks for fixing this @nastra and @ajantha-bhat for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Hive: Make HiveMetastoreExtension configurable [iceberg]

2023-12-13 Thread via GitHub
Fokko merged PR #9288: URL: https://github.com/apache/iceberg/pull/9288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

Re: [PR] Hive: Make HiveMetastoreExtension configurable [iceberg]

2023-12-13 Thread via GitHub
ajantha-bhat commented on code in PR #9288: URL: https://github.com/apache/iceberg/pull/9288#discussion_r1424994351 ## hive-metastore/src/test/java/org/apache/iceberg/hive/HiveMetastoreExtension.java: ## @@ -80,4 +82,27 @@ public HiveConf hiveConf() { public TestHiveMetastore

Re: [PR] Hive: Make HiveMetastoreExtension configurable [iceberg]

2023-12-13 Thread via GitHub
ajantha-bhat commented on code in PR #9288: URL: https://github.com/apache/iceberg/pull/9288#discussion_r1424994351 ## hive-metastore/src/test/java/org/apache/iceberg/hive/HiveMetastoreExtension.java: ## @@ -80,4 +82,27 @@ public HiveConf hiveConf() { public TestHiveMetastore

Re: [PR] Hive: Make HiveMetastoreExtension configurable [iceberg]

2023-12-13 Thread via GitHub
Fokko commented on code in PR #9288: URL: https://github.com/apache/iceberg/pull/9288#discussion_r1424982095 ## hive-metastore/src/test/java/org/apache/iceberg/hive/HiveMetastoreExtension.java: ## @@ -80,4 +82,27 @@ public HiveConf hiveConf() { public TestHiveMetastore metast

Re: [PR] Hive: Make HiveMetastoreExtension configurable [iceberg]

2023-12-12 Thread via GitHub
nastra commented on code in PR #9288: URL: https://github.com/apache/iceberg/pull/9288#discussion_r1424972913 ## hive-metastore/src/test/java/org/apache/iceberg/hive/HiveMetastoreExtension.java: ## @@ -80,4 +82,27 @@ public HiveConf hiveConf() { public TestHiveMetastore metas

Re: [PR] Hive: Make HiveMetastoreExtension configurable [iceberg]

2023-12-12 Thread via GitHub
ajantha-bhat commented on code in PR #9288: URL: https://github.com/apache/iceberg/pull/9288#discussion_r1424967124 ## hive-metastore/src/test/java/org/apache/iceberg/hive/HiveMetastoreExtension.java: ## @@ -80,4 +82,27 @@ public HiveConf hiveConf() { public TestHiveMetastore

[PR] Hive: Make HiveMetastoreExtension configurable [iceberg]

2023-12-12 Thread via GitHub
nastra opened a new pull request, #9288: URL: https://github.com/apache/iceberg/pull/9288 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai