nastra commented on code in PR #9288:
URL: https://github.com/apache/iceberg/pull/9288#discussion_r1424972913
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/HiveMetastoreExtension.java:
##########
@@ -80,4 +82,27 @@ public HiveConf hiveConf() {
public TestHiveMetastore metastore() {
return metastore;
}
+
+ public static Builder builder() {
Review Comment:
I'm not sure I fully understand the question, but we typically try to avoid
adding (multiple) parameters to the builder method as otherwise this is just
mimicking the constructor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
