ajantha-bhat commented on code in PR #9288:
URL: https://github.com/apache/iceberg/pull/9288#discussion_r1424994351
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/HiveMetastoreExtension.java:
##########
@@ -80,4 +82,27 @@ public HiveConf hiveConf() {
public TestHiveMetastore metastore() {
return metastore;
}
+
+ public static Builder builder() {
Review Comment:
I meant have two constructor
HiveMetastoreExtension(DB_NAME, Collections.emptyMap()) -- existing
HiveMetastoreExtension(Collections.emptyMap()) -- new
If DB_NAME is not passed, don't initialize the db.
If we have multiple params, builder makes sense. But for just one param it
might be an overkill.
My suggestion was mainly to avoid making changes in all the tests.
But I don't have strong oppose to the current changes. We can merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
