Fokko commented on code in PR #9288:
URL: https://github.com/apache/iceberg/pull/9288#discussion_r1424982095
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/HiveMetastoreExtension.java:
##########
@@ -80,4 +82,27 @@ public HiveConf hiveConf() {
public TestHiveMetastore metastore() {
return metastore;
}
+
+ public static Builder builder() {
Review Comment:
I see Ajantha's point, but since it is in tests I don't think that it is
really a problem of hiding the constructor, also this makes it more futureproof.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
