github-actions[bot] closed pull request #9924: Hive: Common namespace
validation for HiveCatalog
URL: https://github.com/apache/iceberg/pull/9924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
github-actions[bot] commented on PR #9924:
URL: https://github.com/apache/iceberg/pull/9924#issuecomment-2445551471
This pull request has been closed due to lack of activity. This is not a
judgement on the merit of the PR in any way. It is just a way of keeping the PR
queue manageable. If y
github-actions[bot] commented on PR #9924:
URL: https://github.com/apache/iceberg/pull/9924#issuecomment-2427964396
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
nastra commented on code in PR #9924:
URL: https://github.com/apache/iceberg/pull/9924#discussion_r1530195937
##
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java:
##
@@ -1179,4 +1179,42 @@ public void
testDatabaseLocationWithSlashInWarehouseDir() {
nk1506 commented on code in PR #9924:
URL: https://github.com/apache/iceberg/pull/9924#discussion_r1530162549
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -275,12 +275,7 @@ public void renameTable(TableIdentifier from,
TableIdentifier original
nastra commented on code in PR #9924:
URL: https://github.com/apache/iceberg/pull/9924#discussion_r1530123440
##
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java:
##
@@ -1179,4 +1179,25 @@ public void
testDatabaseLocationWithSlashInWarehouseDir() {
nastra commented on code in PR #9924:
URL: https://github.com/apache/iceberg/pull/9924#discussion_r1530121449
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -275,12 +275,7 @@ public void renameTable(TableIdentifier from,
TableIdentifier original
nastra commented on code in PR #9924:
URL: https://github.com/apache/iceberg/pull/9924#discussion_r1529944747
##
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java:
##
@@ -1179,4 +1179,25 @@ public void
testDatabaseLocationWithSlashInWarehouseDir() {
nk1506 commented on code in PR #9924:
URL: https://github.com/apache/iceberg/pull/9924#discussion_r1529069107
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -554,10 +556,6 @@ private Map convertToMetadata(Database
database) {
}
Database
nk1506 commented on code in PR #9924:
URL: https://github.com/apache/iceberg/pull/9924#discussion_r1529067654
##
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java:
##
@@ -1179,4 +1179,25 @@ public void
testDatabaseLocationWithSlashInWarehouseDir() {
nastra commented on code in PR #9924:
URL: https://github.com/apache/iceberg/pull/9924#discussion_r1528524348
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -554,10 +556,6 @@ private Map convertToMetadata(Database
database) {
}
Database
nk1506 commented on PR #9924:
URL: https://github.com/apache/iceberg/pull/9924#issuecomment-141321
@nastra , please let me know if we have more comments here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
nk1506 commented on code in PR #9924:
URL: https://github.com/apache/iceberg/pull/9924#discussion_r1519550142
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -554,10 +556,6 @@ private Map convertToMetadata(Database
database) {
}
Database
nk1506 commented on code in PR #9924:
URL: https://github.com/apache/iceberg/pull/9924#discussion_r1519550142
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -554,10 +556,6 @@ private Map convertToMetadata(Database
database) {
}
Database
nastra commented on code in PR #9924:
URL: https://github.com/apache/iceberg/pull/9924#discussion_r1519506172
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -554,10 +556,6 @@ private Map convertToMetadata(Database
database) {
}
Database
15 matches
Mail list logo