nastra commented on code in PR #9924:
URL: https://github.com/apache/iceberg/pull/9924#discussion_r1528524348
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -554,10 +556,6 @@ private Map<String, String> convertToMetadata(Database
database) {
}
Database convertToDatabase(Namespace namespace, Map<String, String> meta) {
- if (!isValidateNamespace(namespace)) {
Review Comment:
if the API expects a `NoSuchNamespaceException` then we can't replace it
with a IAE. The exception behavior here should be consistent with
`loadNamespaceMetadata()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
