nk1506 commented on code in PR #9924:
URL: https://github.com/apache/iceberg/pull/9924#discussion_r1529069107
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -554,10 +556,6 @@ private Map<String, String> convertToMetadata(Database
database) {
}
Database convertToDatabase(Namespace namespace, Map<String, String> meta) {
- if (!isValidateNamespace(namespace)) {
Review Comment:
Thanks, Although we should have a common method for this too
```
if (!isValidateNamespace(namespace)) {
throw new NoSuchNamespaceException("Namespace does not exist: %s",
namespace);
}
```
Is it a good idea to use the `checkNamespaceIsValid` with a flag for
`NoSuchNamespaceException` ?
WDYT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
