nk1506 commented on code in PR #9924:
URL: https://github.com/apache/iceberg/pull/9924#discussion_r1530162549


##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -275,12 +275,7 @@ public void renameTable(TableIdentifier from, 
TableIdentifier originalTo) {
 
   @Override
   public void createNamespace(Namespace namespace, Map<String, String> meta) {
-    Preconditions.checkArgument(
-        !namespace.isEmpty(), "Cannot create namespace with invalid name: %s", 
namespace);

Review Comment:
   Sure, I will add it for `HiveCatalog`. I hope you are taking care for 
`CatalogTests`. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to