findepi commented on PR #10518:
URL: https://github.com/apache/iceberg/pull/10518#issuecomment-2263990564
Moved to 1.7.0 milestone per `[VOTE] Drop Java 8 support in Iceberg 1.7.0`
mail list thread. Will merge tomorrow.
--
This is an automated message from the Apache Git Service.
To respo
findepi commented on code in PR #10518:
URL: https://github.com/apache/iceberg/pull/10518#discussion_r1692953386
##
core/src/main/java/org/apache/iceberg/StaticDataTask.java:
##
@@ -127,7 +127,11 @@ DataFile metadataFile() {
return metadataFile;
}
- /** @return the ta
findepi commented on PR #10518:
URL: https://github.com/apache/iceberg/pull/10518#issuecomment-2252597417
Rebased to update formatting in flink/v1.19 classes.
I will move the baseline update commit to separate PR though.
--
This is an automated message from the Apache Git Service.
To re
findepi commented on code in PR #10518:
URL: https://github.com/apache/iceberg/pull/10518#discussion_r1692920958
##
core/src/main/java/org/apache/iceberg/StaticDataTask.java:
##
@@ -127,7 +127,11 @@ DataFile metadataFile() {
return metadataFile;
}
- /** @return the ta
nastra commented on code in PR #10518:
URL: https://github.com/apache/iceberg/pull/10518#discussion_r1692583839
##
core/src/main/java/org/apache/iceberg/StaticDataTask.java:
##
@@ -127,7 +127,11 @@ DataFile metadataFile() {
return metadataFile;
}
- /** @return the tab
findepi commented on PR #10518:
URL: https://github.com/apache/iceberg/pull/10518#issuecomment-2251441830
( rebased to resolve conflicts with now-merged
https://github.com/apache/iceberg/pull/10474, no other changes )
--
This is an automated message from the Apache Git Service.
To respond
steveloughran commented on PR #10518:
URL: https://github.com/apache/iceberg/pull/10518#issuecomment-2241607124
* making java11 your base version is great -but you'll need a followup of
'cut hadoop-2' profile. this is a good thing
* java 22 is going to break a lost as they will cut `Subje
findepi commented on PR #10518:
URL: https://github.com/apache/iceberg/pull/10518#issuecomment-2230268734
@ajantha-bhat it's not really mixed. I intended the thread to focus on
adding 21, but folks decided to focus on dropping 8, so this is all the thread
is about. I wish we could just chan
ajantha-bhat commented on PR #10518:
URL: https://github.com/apache/iceberg/pull/10518#issuecomment-2230159244
> However, there is no agreement yet as to when this should be merged, see
[the thread on the mailing
list](https://lists.apache.org/thread/bn2c480wdbzr089p88n1003zhw0nj9kv).
findepi commented on PR #10518:
URL: https://github.com/apache/iceberg/pull/10518#issuecomment-2230155145
> This PR can also help in unblocking parquet version bump: [#10209
(comment)](https://github.com/apache/iceberg/pull/10209#issuecomment-2230123181)
Thanks @ajantha-bhat for linki
ajantha-bhat commented on PR #10518:
URL: https://github.com/apache/iceberg/pull/10518#issuecomment-2230127463
@snazy, @jbonofre: Can you please also review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
ajantha-bhat commented on PR #10518:
URL: https://github.com/apache/iceberg/pull/10518#issuecomment-2230125351
This PR can also help in unblocking parquet version bump:
https://github.com/apache/iceberg/pull/10209#issuecomment-2230123181
@findepi: Are you still working on this? I thin
findepi commented on code in PR #10518:
URL: https://github.com/apache/iceberg/pull/10518#discussion_r1644403006
##
baseline.gradle:
##
@@ -73,39 +73,57 @@ subprojects {
options.errorprone.errorproneArgs.addAll (
// error-prone is slow, don't run on tests/gener
nastra commented on code in PR #10518:
URL: https://github.com/apache/iceberg/pull/10518#discussion_r1644358132
##
baseline.gradle:
##
@@ -73,39 +73,57 @@ subprojects {
options.errorprone.errorproneArgs.addAll (
// error-prone is slow, don't run on tests/genera
findepi commented on code in PR #10518:
URL: https://github.com/apache/iceberg/pull/10518#discussion_r1644279376
##
baseline.gradle:
##
@@ -73,39 +73,57 @@ subprojects {
options.errorprone.errorproneArgs.addAll (
// error-prone is slow, don't run on tests/gener
nastra commented on code in PR #10518:
URL: https://github.com/apache/iceberg/pull/10518#discussion_r1644271939
##
baseline.gradle:
##
@@ -73,39 +73,57 @@ subprojects {
options.errorprone.errorproneArgs.addAll (
// error-prone is slow, don't run on tests/genera
findepi opened a new pull request, #10518:
URL: https://github.com/apache/iceberg/pull/10518
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
17 matches
Mail list logo
