findepi commented on code in PR #10518:
URL: https://github.com/apache/iceberg/pull/10518#discussion_r1644279376
##########
baseline.gradle:
##########
@@ -73,39 +73,57 @@ subprojects {
options.errorprone.errorproneArgs.addAll (
// error-prone is slow, don't run on tests/generated-src/generated
'-XepExcludedPaths:.*/(test|generated-src|generated)/.*',
- // specific to Palantir
- '-Xep:ConsistentLoggerName:OFF', // Uses name `log` but we use name
`LOG`
- '-Xep:FinalClass:OFF',
- '-Xep:PreferSafeLoggingPreconditions:OFF',
- '-Xep:PreferSafeLoggableExceptions:OFF',
- '-Xep:Slf4jLogsafeArgs:OFF',
- '-Xep:RawTypes:OFF',
- // enforce logging conventions
- '-Xep:LoggerEnclosingClass:ERROR',
- '-Xep:PreferStaticLoggers:ERROR',
- '-Xep:Slf4jThrowable:ERROR',
+ '-Xep:AnnotateFormatMethod:ERROR',
Review Comment:
Agreed, it looks like a mess.
Does reviewing commit by commit help?
One of the early commits is `Sort error-prone configuration options`.
Obviously it blurs the picture for this PR, but should help going forward. Do
you think such a change helps?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
