nastra commented on code in PR #10518:
URL: https://github.com/apache/iceberg/pull/10518#discussion_r1644358132
##########
baseline.gradle:
##########
@@ -73,39 +73,57 @@ subprojects {
options.errorprone.errorproneArgs.addAll (
// error-prone is slow, don't run on tests/generated-src/generated
'-XepExcludedPaths:.*/(test|generated-src|generated)/.*',
- // specific to Palantir
- '-Xep:ConsistentLoggerName:OFF', // Uses name `log` but we use name
`LOG`
- '-Xep:FinalClass:OFF',
- '-Xep:PreferSafeLoggingPreconditions:OFF',
- '-Xep:PreferSafeLoggableExceptions:OFF',
- '-Xep:Slf4jLogsafeArgs:OFF',
- '-Xep:RawTypes:OFF',
- // enforce logging conventions
- '-Xep:LoggerEnclosingClass:ERROR',
- '-Xep:PreferStaticLoggers:ERROR',
- '-Xep:Slf4jThrowable:ERROR',
+ '-Xep:AnnotateFormatMethod:ERROR',
Review Comment:
the change itself doesn't seem related to dropping JDK 8 support, so I don't
see a strong reason to sort the configurations in this PR. Also most people (me
included) typically look at the entire diff rather than looking at individual
commits (as all commits will be squashed together anyway at the end)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
