findepi commented on code in PR #10518:
URL: https://github.com/apache/iceberg/pull/10518#discussion_r1644403006
##########
baseline.gradle:
##########
@@ -73,39 +73,57 @@ subprojects {
options.errorprone.errorproneArgs.addAll (
// error-prone is slow, don't run on tests/generated-src/generated
'-XepExcludedPaths:.*/(test|generated-src|generated)/.*',
- // specific to Palantir
- '-Xep:ConsistentLoggerName:OFF', // Uses name `log` but we use name
`LOG`
- '-Xep:FinalClass:OFF',
- '-Xep:PreferSafeLoggingPreconditions:OFF',
- '-Xep:PreferSafeLoggableExceptions:OFF',
- '-Xep:Slf4jLogsafeArgs:OFF',
- '-Xep:RawTypes:OFF',
- // enforce logging conventions
- '-Xep:LoggerEnclosingClass:ERROR',
- '-Xep:PreferStaticLoggers:ERROR',
- '-Xep:Slf4jThrowable:ERROR',
+ '-Xep:AnnotateFormatMethod:ERROR',
Review Comment:
> as all commits will be squashed together anyway at the end
is it a project rule, or the merging person's preference?
i tend to keep the PR's commit tidy & in order
> the change itself doesn't seem related to dropping JDK 8 support, so I
don't see a strong reason to sort the configurations in this PR.
you're right!
There is "drop 8" change, which doesn't affect error-prone by itself, and
then there is also update error-prone plugin commit which does.
I keep these changes in one PR because it's easier to manage this way &
we're not ready to drop 8 yet. I can separate when needed. For example, do you
think it'd help if i extracted `Sort error-prone configuration options` to a
separate PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
