ggershinsky commented on code in PR #9359:
URL: https://github.com/apache/iceberg/pull/9359#discussion_r1435812202
##
core/src/main/java/org/apache/iceberg/avro/Avro.java:
##
@@ -91,6 +92,13 @@ public static WriteBuilder write(OutputFile file) {
return new WriteBuilder(file
ggershinsky commented on code in PR #9359:
URL: https://github.com/apache/iceberg/pull/9359#discussion_r1434752900
##
core/src/main/java/org/apache/iceberg/avro/Avro.java:
##
@@ -91,6 +92,13 @@ public static WriteBuilder write(OutputFile file) {
return new WriteBuilder(file
rdblue commented on code in PR #9359:
URL: https://github.com/apache/iceberg/pull/9359#discussion_r1434450493
##
core/src/main/java/org/apache/iceberg/avro/Avro.java:
##
@@ -91,6 +92,13 @@ public static WriteBuilder write(OutputFile file) {
return new WriteBuilder(file);
rdblue commented on code in PR #9359:
URL: https://github.com/apache/iceberg/pull/9359#discussion_r1434433368
##
core/src/main/java/org/apache/iceberg/avro/Avro.java:
##
@@ -91,6 +92,13 @@ public static WriteBuilder write(OutputFile file) {
return new WriteBuilder(file);
ggershinsky commented on PR #9359:
URL: https://github.com/apache/iceberg/pull/9359#issuecomment-1866785085
The last round of comments in #6762 is addressed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
ggershinsky commented on PR #6762:
URL: https://github.com/apache/iceberg/pull/6762#issuecomment-1866291510
Moved to main branch base via #9359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ggershinsky closed pull request #6762: Deliver key metadata to parquet
encryption
URL: https://github.com/apache/iceberg/pull/6762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
ggershinsky opened a new pull request, #9359:
URL: https://github.com/apache/iceberg/pull/9359
Moving #6762 to main branch base
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
ggershinsky commented on code in PR #6762:
URL: https://github.com/apache/iceberg/pull/6762#discussion_r1433750688
##
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkAppenderFactory.java:
##
@@ -175,15 +181,15 @@ public FileAppender newAppender(OutputFile
fi
ggershinsky commented on code in PR #6762:
URL: https://github.com/apache/iceberg/pull/6762#discussion_r1433602851
##
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##
@@ -125,6 +127,16 @@ public static WriteBuilder write(OutputFile file) {
return new WriteB
ggershinsky commented on code in PR #6762:
URL: https://github.com/apache/iceberg/pull/6762#discussion_r1433548058
##
data/src/main/java/org/apache/iceberg/data/BaseFileWriterFactory.java:
##
@@ -118,7 +118,7 @@ public DataWriter newDataWriter(
case PARQUET:
ggershinsky commented on code in PR #6762:
URL: https://github.com/apache/iceberg/pull/6762#discussion_r1433532466
##
data/src/main/java/org/apache/iceberg/data/GenericReader.java:
##
@@ -126,6 +128,13 @@ private CloseableIterable openFile(FileScanTask
task, Schema fileProject
rdblue commented on code in PR #6762:
URL: https://github.com/apache/iceberg/pull/6762#discussion_r1421850518
##
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkAppenderFactory.java:
##
@@ -175,15 +181,15 @@ public FileAppender newAppender(OutputFile
file, F
rdblue commented on code in PR #6762:
URL: https://github.com/apache/iceberg/pull/6762#discussion_r1421849186
##
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##
@@ -125,6 +127,16 @@ public static WriteBuilder write(OutputFile file) {
return new WriteBuilde
rdblue commented on code in PR #6762:
URL: https://github.com/apache/iceberg/pull/6762#discussion_r1421846390
##
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##
@@ -125,6 +127,16 @@ public static WriteBuilder write(OutputFile file) {
return new WriteBuilde
rdblue commented on code in PR #6762:
URL: https://github.com/apache/iceberg/pull/6762#discussion_r1421846643
##
core/src/main/java/org/apache/iceberg/encryption/EncryptionUtil.java:
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mo
rdblue commented on code in PR #6762:
URL: https://github.com/apache/iceberg/pull/6762#discussion_r1421846390
##
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##
@@ -125,6 +127,16 @@ public static WriteBuilder write(OutputFile file) {
return new WriteBuilde
rdblue commented on code in PR #6762:
URL: https://github.com/apache/iceberg/pull/6762#discussion_r1421846049
##
data/src/main/java/org/apache/iceberg/data/GenericAppenderFactory.java:
##
@@ -146,10 +154,12 @@ public EqualityDeleteWriter newEqDeleteWriter(
"Equality del
rdblue commented on code in PR #6762:
URL: https://github.com/apache/iceberg/pull/6762#discussion_r1421845271
##
data/src/main/java/org/apache/iceberg/data/BaseFileWriterFactory.java:
##
@@ -118,7 +118,7 @@ public DataWriter newDataWriter(
case PARQUET:
Par
rdblue commented on code in PR #6762:
URL: https://github.com/apache/iceberg/pull/6762#discussion_r1421845271
##
data/src/main/java/org/apache/iceberg/data/BaseFileWriterFactory.java:
##
@@ -118,7 +118,7 @@ public DataWriter newDataWriter(
case PARQUET:
Par
rdblue commented on code in PR #6762:
URL: https://github.com/apache/iceberg/pull/6762#discussion_r1421844932
##
data/src/main/java/org/apache/iceberg/data/DeleteFilter.java:
##
@@ -293,6 +295,13 @@ private CloseableIterable openDeletes(DeleteFile
deleteFile, Schema dele
rdblue commented on code in PR #6762:
URL: https://github.com/apache/iceberg/pull/6762#discussion_r1421844741
##
data/src/main/java/org/apache/iceberg/data/GenericReader.java:
##
@@ -126,6 +128,13 @@ private CloseableIterable openFile(FileScanTask
task, Schema fileProject
ggershinsky commented on code in PR #6762:
URL: https://github.com/apache/iceberg/pull/6762#discussion_r1361569389
##
core/src/main/java/org/apache/iceberg/encryption/BaseEncryptedOutputFile.java:
##
@@ -24,10 +24,19 @@ class BaseEncryptedOutputFile implements
EncryptedOutputFi
ggershinsky commented on code in PR #6762:
URL: https://github.com/apache/iceberg/pull/6762#discussion_r1342920622
##
api/src/main/java/org/apache/iceberg/encryption/EncryptionKeyMetadata.java:
##
@@ -49,4 +54,12 @@ static EncryptionKeyMetadata empty() {
ByteBuffer buffer();
24 matches
Mail list logo
