ggershinsky commented on code in PR #6762:
URL: https://github.com/apache/iceberg/pull/6762#discussion_r1433602851


##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -125,6 +127,16 @@ public static WriteBuilder write(OutputFile file) {
     return new WriteBuilder(file);
   }
 
+  public static WriteBuilder write(EncryptedOutputFile file) {
+    if (EncryptionUtil.useNativeEncryption(file.keyMetadata())) {
+      return write(file.rawOutputFile())
+          .withFileEncryptionKey(file.keyMetadata().encryptionKey())

Review Comment:
   +1 to the first suggestion.
   
   As for the second - this `WriterBuilder` class doesn't have a 
`withKeyMetadata` method (since it is a basic writer appender).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to