rdblue commented on code in PR #6762:
URL: https://github.com/apache/iceberg/pull/6762#discussion_r1421844741
##########
data/src/main/java/org/apache/iceberg/data/GenericReader.java:
##########
@@ -126,6 +128,13 @@ private CloseableIterable<Record> openFile(FileScanTask
task, Schema fileProject
parquet.reuseContainers();
}
+ if (task.file().keyMetadata() != null) {
+ EncryptionKeyMetadata keyMetadata =
Review Comment:
This method in `EncryptionUtil` returns a package-private implementation,
`KeyMetadata`. That leaks the class outside of the package but it isn't useful.
I think that's why this added methods to `EncryptionKeyMetadata`. I think it's
better to make `KeyMetadata` (or `StandardKeyMetadata` as I renamed it in my
last PR) public.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
