rdblue commented on code in PR #6762:
URL: https://github.com/apache/iceberg/pull/6762#discussion_r1421845271
##########
data/src/main/java/org/apache/iceberg/data/BaseFileWriterFactory.java:
##########
@@ -118,7 +118,7 @@ public DataWriter<T> newDataWriter(
case PARQUET:
Parquet.DataWriteBuilder parquetBuilder =
- Parquet.writeData(outputFile)
+ Parquet.writeData(file)
Review Comment:
Since `encryptingOutputFile` will create an `AesGcmOutputFile`, I don't
think it should be called unless it is going to be used. I think `outputFile`
should be removed and the branches that pass an `OutputFile` (ORC and Avro)
should call `file.encryptingOutputFile()` inline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
