Re: [PR] Create ExtensionTestBase for migration to JUnit5 [iceberg]

nastra merged PR #9613: URL: https://github.com/apache/iceberg/pull/9613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Create ExtensionTestBase for migration to JUnit5 [iceberg]

tomtongue commented on PR #9613: URL: https://github.com/apache/iceberg/pull/9613#issuecomment-1923454127 @nastra thanks a lot for the review. I will create a new PR to move other classes in the extension after this. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Create ExtensionTestBase for migration to JUnit5 [iceberg]

tomtongue commented on code in PR #9613: URL: https://github.com/apache/iceberg/pull/9613#discussion_r1475762390 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java: ## @@ -48,18 +49,15 @@ import org.apache.spark.sql.types

Re: [PR] Create ExtensionTestBase for migration to JUnit5 [iceberg]

nastra commented on code in PR #9613: URL: https://github.com/apache/iceberg/pull/9613#discussion_r1475754953 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java: ## @@ -85,34 +83,26 @@ public static Object[][] parameters()

Re: [PR] Create ExtensionTestBase for migration to JUnit5 [iceberg]

nastra commented on code in PR #9613: URL: https://github.com/apache/iceberg/pull/9613#discussion_r1475752328 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java: ## @@ -48,18 +49,15 @@ import org.apache.spark.sql.types.St

Re: [PR] Create ExtensionTestBase for migration to JUnit5 [iceberg]

tomtongue commented on code in PR #9613: URL: https://github.com/apache/iceberg/pull/9613#discussion_r1475750608 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java: ## @@ -485,14 +475,14 @@ public void addPartitionToParti

Re: [PR] Create ExtensionTestBase for migration to JUnit5 [iceberg]

nastra commented on PR #9613: URL: https://github.com/apache/iceberg/pull/9613#issuecomment-1923353317 please also add the below diff to `iceberg-spark-extensions` so that JUnit5 tests are properly executed ``` diff --git a/spark/v3.5/build.gradle b/spark/v3.5/build.gradle index eee

Re: [PR] Create ExtensionTestBase for migration to JUnit5 [iceberg]

nastra commented on code in PR #9613: URL: https://github.com/apache/iceberg/pull/9613#discussion_r1475743885 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java: ## @@ -485,14 +475,14 @@ public void addPartitionToPartitio

Re: [PR] Create ExtensionTestBase for migration to JUnit5 [iceberg]

nastra commented on code in PR #9613: URL: https://github.com/apache/iceberg/pull/9613#discussion_r1475743107 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java: ## @@ -171,19 +161,19 @@ public void addDataUnpartitionedOrc

Re: [PR] Create ExtensionTestBase for migration to JUnit5 [iceberg]

tomtongue commented on code in PR #9613: URL: https://github.com/apache/iceberg/pull/9613#discussion_r1475725464 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java: ## @@ -85,34 +83,26 @@ public static Object[][] parameter

Re: [PR] Create ExtensionTestBase for migration to JUnit5 [iceberg]

tomtongue commented on code in PR #9613: URL: https://github.com/apache/iceberg/pull/9613#discussion_r1475738347 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/ExtensionsTestBase.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software

Re: [PR] Create ExtensionTestBase for migration to JUnit5 [iceberg]

tomtongue commented on code in PR #9613: URL: https://github.com/apache/iceberg/pull/9613#discussion_r1475725464 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java: ## @@ -85,34 +83,26 @@ public static Object[][] parameter

Re: [PR] Create ExtensionTestBase for migration to JUnit5 [iceberg]

tomtongue commented on code in PR #9613: URL: https://github.com/apache/iceberg/pull/9613#discussion_r1475691097 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java: ## @@ -489,10 +479,10 @@ public void addPartitionToParti

Re: [PR] Create ExtensionTestBase for migration to JUnit5 [iceberg]

tomtongue commented on code in PR #9613: URL: https://github.com/apache/iceberg/pull/9613#discussion_r1474620013 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java: ## @@ -171,19 +161,19 @@ public void addDataUnpartitioned

Re: [PR] Create ExtensionTestBase for migration to JUnit5 [iceberg]

nastra commented on code in PR #9613: URL: https://github.com/apache/iceberg/pull/9613#discussion_r1474606607 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java: ## @@ -85,34 +83,26 @@ public static Object[][] parameters()

Re: [PR] Create ExtensionTestBase for migration to JUnit5 [iceberg]

nastra commented on code in PR #9613: URL: https://github.com/apache/iceberg/pull/9613#discussion_r1474602163 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java: ## @@ -489,10 +479,10 @@ public void addPartitionToPartitio

Re: [PR] Create ExtensionTestBase for migration to JUnit5 [iceberg]

nastra commented on code in PR #9613: URL: https://github.com/apache/iceberg/pull/9613#discussion_r1474602163 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java: ## @@ -489,10 +479,10 @@ public void addPartitionToPartitio

Re: [PR] Create ExtensionTestBase for migration to JUnit5 [iceberg]

nastra commented on code in PR #9613: URL: https://github.com/apache/iceberg/pull/9613#discussion_r1474598831 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java: ## @@ -248,15 +238,15 @@ public void addDataUnpartitionedAvr

Re: [PR] Create ExtensionTestBase for migration to JUnit5 [iceberg]

nastra commented on code in PR #9613: URL: https://github.com/apache/iceberg/pull/9613#discussion_r1474598148 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java: ## @@ -199,7 +189,7 @@ public void addAvroFile() throws Exce

Re: [PR] Create ExtensionTestBase for migration to JUnit5 [iceberg]

nastra commented on code in PR #9613: URL: https://github.com/apache/iceberg/pull/9613#discussion_r1474596532 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java: ## @@ -171,19 +161,19 @@ public void addDataUnpartitionedOrc

Re: [PR] Create ExtensionTestBase for migration to JUnit5 [iceberg]

nastra commented on code in PR #9613: URL: https://github.com/apache/iceberg/pull/9613#discussion_r1474594754 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java: ## @@ -85,34 +83,26 @@ public static Object[][] parameters()

Re: [PR] Create ExtensionTestBase for migration to JUnit5 [iceberg]

nastra commented on code in PR #9613: URL: https://github.com/apache/iceberg/pull/9613#discussion_r1474592921 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/ExtensionsTestBase.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Create ExtensionTestBase for migration to JUnit5 [iceberg]

nastra commented on code in PR #9613: URL: https://github.com/apache/iceberg/pull/9613#discussion_r1474593904 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java: ## @@ -85,34 +83,26 @@ public static Object[][] parameters()

Re: [PR] Create ExtensionTestBase for migration to JUnit5 [iceberg]

nastra commented on code in PR #9613: URL: https://github.com/apache/iceberg/pull/9613#discussion_r1474592362 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/ExtensionsTestBase.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Fou

[PR] Create ExtensionTestBase for migration to JUnit5 [iceberg]

tomtongue opened a new pull request, #9613: URL: https://github.com/apache/iceberg/pull/9613 Create `ExtensionTestBase` to migrate current tests in SparkExtension to JUnit 5 in regards to https://github.com/apache/iceberg/issues/9086. For now, only one test `TestAddFilesProcedure` is