nastra commented on code in PR #9613:
URL: https://github.com/apache/iceberg/pull/9613#discussion_r1475743107
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java:
##########
@@ -171,19 +161,19 @@ public void addDataUnpartitionedOrc() {
"CALL %s.system.add_files('%s', '`orc`.`%s`')",
catalogName, tableName, fileTableDir.getAbsolutePath());
- Assert.assertEquals(2L, result);
+ Assertions.assertThat(result).isEqualTo(2L);
Review Comment:
please use the statically imported method
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java:
##########
@@ -171,19 +161,19 @@ public void addDataUnpartitionedOrc() {
"CALL %s.system.add_files('%s', '`orc`.`%s`')",
catalogName, tableName, fileTableDir.getAbsolutePath());
- Assert.assertEquals(2L, result);
+ Assertions.assertThat(result).isEqualTo(2L);
assertEquals(
"Iceberg table contains correct data",
sql("SELECT * FROM %s ORDER BY id", sourceTableName),
sql("SELECT * FROM %s ORDER BY id", tableName));
}
- @Test
+ @TestTemplate
public void addAvroFile() throws Exception {
// Spark Session Catalog cannot load metadata tables
// with "The namespace in session catalog must have exactly one name part"
- Assume.assumeFalse(catalogName.equals("spark_catalog"));
+ Assumptions.assumeThat(catalogName).isNotEqualTo("spark_catalog");
Review Comment:
please use the statically imported method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
