tomtongue commented on code in PR #9613:
URL: https://github.com/apache/iceberg/pull/9613#discussion_r1475725464
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java:
##########
@@ -85,34 +83,26 @@ public static Object[][] parameters() {
};
}
- private final int formatVersion;
+ @Parameter(index = 3)
+ protected int formatVersion;
+
private final String sourceTableName = "source_table";
private File fileTableDir;
- public TestAddFilesProcedure(
- String catalogName, String implementation, Map<String, String> config,
int formatVersion) {
- super(catalogName, implementation, config);
- this.formatVersion = formatVersion;
- }
-
- @Rule public TemporaryFolder temp = new TemporaryFolder();
+ @TempDir protected Path temp;
- @Before
+ @BeforeEach
public void setupTempDirs() {
- try {
- fileTableDir = temp.newFolder();
- } catch (IOException e) {
- throw new RuntimeException(e);
- }
+ fileTableDir = temp.toFile();
Review Comment:
I believe `temp.toFile().getAbsolutePath()` is evaluated in the sql and I
couldn't find any errors based on my several attempts. However, `fileTableDir`
is called 33 times in this class, and keep the current one is less changes.
What do you think? (committed without changes for now)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
