Re: [PR] Core: Write `null` for `current-snapshot-id` for V3+ [iceberg]

Fokko merged PR #12335: URL: https://github.com/apache/iceberg/pull/12335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] Core: Write `null` for `current-snapshot-id` for V3+ [iceberg]

Fokko commented on PR #12335: URL: https://github.com/apache/iceberg/pull/12335#issuecomment-2703016795 Moving this forward, thanks @nastra and @RussellSpitzer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] Core: Write `null` for `current-snapshot-id` for V3+ [iceberg]

Fokko commented on code in PR #12335: URL: https://github.com/apache/iceberg/pull/12335#discussion_r1968210910 ## core/src/main/java/org/apache/iceberg/TableMetadataParser.java: ## @@ -216,9 +216,15 @@ public static void toJson(TableMetadata metadata, JsonGenerator generator) t

Re: [PR] Core: Write `null` for `current-snapshot-id` for V3+ [iceberg]

Fokko commented on code in PR #12335: URL: https://github.com/apache/iceberg/pull/12335#discussion_r1962370324 ## core/src/test/java/org/apache/iceberg/rest/responses/TestLoadTableResponseParser.java: ## @@ -56,11 +58,12 @@ public void missingFields() { .hasMessage("Can

Re: [PR] Core: Write `null` for `current-snapshot-id` for V3+ [iceberg]

RussellSpitzer commented on code in PR #12335: URL: https://github.com/apache/iceberg/pull/12335#discussion_r1962355850 ## core/src/test/java/org/apache/iceberg/rest/responses/TestLoadTableResponseParser.java: ## @@ -56,11 +58,12 @@ public void missingFields() { .hasMes

Re: [PR] Core: Write `null` for `current-snapshot-id` for V3+ [iceberg]

Fokko commented on code in PR #12335: URL: https://github.com/apache/iceberg/pull/12335#discussion_r1962353455 ## core/src/test/java/org/apache/iceberg/rest/responses/TestLoadTableResponseParser.java: ## @@ -56,11 +58,12 @@ public void missingFields() { .hasMessage("Can

Re: [PR] Core: Write `null` for `current-snapshot-id` for V3+ [iceberg]

RussellSpitzer commented on code in PR #12335: URL: https://github.com/apache/iceberg/pull/12335#discussion_r1962045057 ## core/src/test/java/org/apache/iceberg/rest/responses/TestLoadTableResponseParser.java: ## @@ -56,11 +58,12 @@ public void missingFields() { .hasMes

Re: [PR] Core: Write `null` for `current-snapshot-id` for V3+ [iceberg]

RussellSpitzer commented on code in PR #12335: URL: https://github.com/apache/iceberg/pull/12335#discussion_r1962049988 ## core/src/test/java/org/apache/iceberg/rest/responses/TestLoadTableResponseParser.java: ## @@ -56,11 +58,12 @@ public void missingFields() { .hasMes

Re: [PR] Core: Write `null` for `current-snapshot-id` for V3+ [iceberg]

RussellSpitzer commented on code in PR #12335: URL: https://github.com/apache/iceberg/pull/12335#discussion_r1962049988 ## core/src/test/java/org/apache/iceberg/rest/responses/TestLoadTableResponseParser.java: ## @@ -56,11 +58,12 @@ public void missingFields() { .hasMes

Re: [PR] Core: Write `null` for `current-snapshot-id` for V3+ [iceberg]

RussellSpitzer commented on code in PR #12335: URL: https://github.com/apache/iceberg/pull/12335#discussion_r1961971576 ## core/src/main/java/org/apache/iceberg/TableMetadataParser.java: ## @@ -216,9 +216,15 @@ public static void toJson(TableMetadata metadata, JsonGenerator gen

Re: [PR] Core: Write `null` for `current-snapshot-id` for V3+ [iceberg]

Fokko commented on code in PR #12335: URL: https://github.com/apache/iceberg/pull/12335#discussion_r1961993212 ## core/src/test/java/org/apache/iceberg/rest/responses/TestLoadTableResponseParser.java: ## @@ -56,11 +59,14 @@ public void missingFields() { .hasMessage("Can

Re: [PR] Core: Write `null` for `current-snapshot-id` for V3+ [iceberg]

nastra commented on code in PR #12335: URL: https://github.com/apache/iceberg/pull/12335#discussion_r1961979564 ## core/src/test/java/org/apache/iceberg/rest/responses/TestLoadTableResponseParser.java: ## @@ -56,11 +59,14 @@ public void missingFields() { .hasMessage("Ca

Re: [PR] Core: Write `null` for `current-snapshot-id` for V3+ [iceberg]

Fokko commented on code in PR #12335: URL: https://github.com/apache/iceberg/pull/12335#discussion_r1961966259 ## core/src/test/java/org/apache/iceberg/rest/responses/TestLoadTableResponseParser.java: ## @@ -58,71 +59,73 @@ public void missingFields() { @Test public void

Re: [PR] Core: Write `null` for `current-snapshot-id` for V3+ [iceberg]

nastra commented on code in PR #12335: URL: https://github.com/apache/iceberg/pull/12335#discussion_r1961559890 ## core/src/test/java/org/apache/iceberg/rest/responses/TestLoadTableResponseParser.java: ## @@ -58,71 +59,73 @@ public void missingFields() { @Test public voi

Re: [PR] Core: Write `null` for `current-snapshot-id` for V3+ [iceberg]

Fokko commented on code in PR #12335: URL: https://github.com/apache/iceberg/pull/12335#discussion_r1961393699 ## core/src/test/java/org/apache/iceberg/rest/responses/TestLoadTableResponseParser.java: ## @@ -58,71 +59,73 @@ public void missingFields() { @Test public void

[PR] Core: Write `null` for `current-snapshot-id` for V3+ [iceberg]

Fokko opened a new pull request, #12335: URL: https://github.com/apache/iceberg/pull/12335 See https://lists.apache.org/thread/gqqsnww6nqc50pddwn29blzghmb0m0h3 Closes #12310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH