RussellSpitzer commented on code in PR #12335:
URL: https://github.com/apache/iceberg/pull/12335#discussion_r1962355850


##########
core/src/test/java/org/apache/iceberg/rest/responses/TestLoadTableResponseParser.java:
##########
@@ -56,11 +58,12 @@ public void missingFields() {
         .hasMessage("Cannot parse missing field: metadata");
   }
 
-  @Test
-  public void roundTripSerde() {
+  @ParameterizedTest
+  @ValueSource(ints = {2, 3})

Review Comment:
   Ah sorry Default Values min format version was just an example, for this 
test you could probably just use 2 if you think 1 isn't worth testing in this 
suite.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to