Fokko commented on code in PR #12335:
URL: https://github.com/apache/iceberg/pull/12335#discussion_r1962353455
##########
core/src/test/java/org/apache/iceberg/rest/responses/TestLoadTableResponseParser.java:
##########
@@ -56,11 +58,12 @@ public void missingFields() {
.hasMessage("Cannot parse missing field: metadata");
}
- @Test
- public void roundTripSerde() {
+ @ParameterizedTest
+ @ValueSource(ints = {2, 3})
Review Comment:
@RussellSpitzer The V1 table format is pretty different. `schema`,
`partition-spec` etc are required for V1, where V2+ uses `schemas`,
`partitions-specs` etc. If you like I can add it as a separate test.
`DEFAULT_VALUES_MIN_FORMAT_VERSION` is private, but `MAX_FORMAT_VERSION` is
a great suggestion 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
