Fokko commented on code in PR #12335:
URL: https://github.com/apache/iceberg/pull/12335#discussion_r1961393699
##########
core/src/test/java/org/apache/iceberg/rest/responses/TestLoadTableResponseParser.java:
##########
@@ -58,71 +59,73 @@ public void missingFields() {
@Test
public void roundTripSerde() {
- String uuid = "386b9f01-002b-4d8c-b77f-42c3fd3b7c9b";
- TableMetadata metadata =
- TableMetadata.buildFromEmpty()
- .assignUUID(uuid)
- .setLocation("location")
- .setCurrentSchema(
- new Schema(Types.NestedField.required(1, "x",
Types.LongType.get())), 1)
- .addPartitionSpec(PartitionSpec.unpartitioned())
- .addSortOrder(SortOrder.unsorted())
- .discardChanges()
- .withMetadataLocation("metadata-location")
- .build();
+ for (int formatVersion : Arrays.asList(2, 3)) {
Review Comment:
I don't want to run all the tests for each format, let me know if there is a
better way to do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
