Re: [PR] Core: Mark `503: added_snapshot_id` as required [iceberg]

2024-09-26 Thread via GitHub
github-actions[bot] commented on PR #8673: URL: https://github.com/apache/iceberg/pull/8673#issuecomment-2378158030 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [PR] Core: Mark `503: added_snapshot_id` as required [iceberg]

2024-09-26 Thread via GitHub
github-actions[bot] closed pull request #8673: Core: Mark `503: added_snapshot_id` as required URL: https://github.com/apache/iceberg/pull/8673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Core: Mark `503: added_snapshot_id` as required [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on PR #8673: URL: https://github.com/apache/iceberg/pull/8673#issuecomment-2362461861 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] Core: Mark `503: added_snapshot_id` as required [iceberg]

2023-10-08 Thread via GitHub
Fokko commented on code in PR #8673: URL: https://github.com/apache/iceberg/pull/8673#discussion_r1349779777 ## core/src/main/java/org/apache/iceberg/V2Metadata.java: ## @@ -39,7 +39,7 @@ private V2Metadata() {} ManifestFile.MANIFEST_CONTENT.asRequired(), M

Re: [PR] Core: Mark `503: added_snapshot_id` as required [iceberg]

2023-10-06 Thread via GitHub
Fokko commented on code in PR #8673: URL: https://github.com/apache/iceberg/pull/8673#discussion_r1348841775 ## core/src/main/java/org/apache/iceberg/GenericManifestFile.java: ## @@ -84,15 +84,24 @@ public GenericManifestFile(Schema avroSchema) { } } + /** + * @depr

Re: [PR] Core: Mark `503: added_snapshot_id` as required [iceberg]

2023-10-06 Thread via GitHub
Fokko commented on code in PR #8673: URL: https://github.com/apache/iceberg/pull/8673#discussion_r1348436509 ## core/src/main/java/org/apache/iceberg/GenericManifestFile.java: ## @@ -84,15 +84,24 @@ public GenericManifestFile(Schema avroSchema) { } } + /** + * @depr

Re: [PR] Core: Mark `503: added_snapshot_id` as required [iceberg]

2023-10-06 Thread via GitHub
Fokko commented on code in PR #8673: URL: https://github.com/apache/iceberg/pull/8673#discussion_r1348395371 ## core/src/main/java/org/apache/iceberg/V2Metadata.java: ## @@ -39,7 +39,7 @@ private V2Metadata() {} ManifestFile.MANIFEST_CONTENT.asRequired(), M

Re: [PR] Core: Mark `503: added_snapshot_id` as required [iceberg]

2023-10-05 Thread via GitHub
rdblue commented on code in PR #8673: URL: https://github.com/apache/iceberg/pull/8673#discussion_r1348100841 ## core/src/main/java/org/apache/iceberg/GenericManifestFile.java: ## @@ -84,15 +84,24 @@ public GenericManifestFile(Schema avroSchema) { } } + /** + * @dep

Re: [PR] Core: Mark `503: added_snapshot_id` as required [iceberg]

2023-10-05 Thread via GitHub
rdblue commented on code in PR #8673: URL: https://github.com/apache/iceberg/pull/8673#discussion_r1348099841 ## core/src/main/java/org/apache/iceberg/V2Metadata.java: ## @@ -39,7 +39,7 @@ private V2Metadata() {} ManifestFile.MANIFEST_CONTENT.asRequired(),

Re: [PR] Core: Mark `503: added_snapshot_id` as required [iceberg]

2023-10-05 Thread via GitHub
Fokko commented on code in PR #8673: URL: https://github.com/apache/iceberg/pull/8673#discussion_r1347949961 ## api/src/main/java/org/apache/iceberg/ManifestFile.java: ## @@ -49,7 +49,7 @@ public interface ManifestFile { Types.LongType.get(), "Lowest sequen

Re: [PR] Core: Mark `503: added_snapshot_id` as required [iceberg]

2023-10-05 Thread via GitHub
Fokko commented on code in PR #8673: URL: https://github.com/apache/iceberg/pull/8673#discussion_r1347814559 ## core/src/main/java/org/apache/iceberg/GenericManifestFile.java: ## @@ -92,7 +92,7 @@ public GenericManifestFile(Schema avroSchema) { this.specId = specId; th

Re: [PR] Core: Mark `503: added_snapshot_id` as required [iceberg]

2023-10-05 Thread via GitHub
Fokko commented on code in PR #8673: URL: https://github.com/apache/iceberg/pull/8673#discussion_r1347466602 ## core/src/main/java/org/apache/iceberg/GenericManifestFile.java: ## @@ -92,7 +92,7 @@ public GenericManifestFile(Schema avroSchema) { this.specId = specId; th

Re: [PR] Core: Mark `503: added_snapshot_id` as required [iceberg]

2023-10-05 Thread via GitHub
Fokko commented on code in PR #8673: URL: https://github.com/apache/iceberg/pull/8673#discussion_r1347466602 ## core/src/main/java/org/apache/iceberg/GenericManifestFile.java: ## @@ -92,7 +92,7 @@ public GenericManifestFile(Schema avroSchema) { this.specId = specId; th

Re: [PR] Core: Mark `503: added_snapshot_id` as required [iceberg]

2023-10-05 Thread via GitHub
Fokko commented on code in PR #8673: URL: https://github.com/apache/iceberg/pull/8673#discussion_r1347459324 ## core/src/main/java/org/apache/iceberg/GenericManifestFile.java: ## @@ -92,7 +92,7 @@ public GenericManifestFile(Schema avroSchema) { this.specId = specId; th

Re: [PR] Core: Mark `503: added_snapshot_id` as required [iceberg]

2023-10-05 Thread via GitHub
amogh-jahagirdar commented on code in PR #8673: URL: https://github.com/apache/iceberg/pull/8673#discussion_r1347419881 ## core/src/main/java/org/apache/iceberg/GenericManifestFile.java: ## @@ -92,7 +92,7 @@ public GenericManifestFile(Schema avroSchema) { this.specId = spec