Fokko commented on code in PR #8673: URL: https://github.com/apache/iceberg/pull/8673#discussion_r1347814559
########## core/src/main/java/org/apache/iceberg/GenericManifestFile.java: ########## @@ -92,7 +92,7 @@ public GenericManifestFile(Schema avroSchema) { this.specId = specId; this.sequenceNumber = 0; this.minSequenceNumber = 0; - this.snapshotId = null; + this.snapshotId = 0L; Review Comment: Hey @amogh-jahagirdar I looked at it once more, and it looks like the Snapshot-ID is available, so no need in setting it to `0L`. Thanks for pointing this out -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org