Fokko commented on code in PR #8673:
URL: https://github.com/apache/iceberg/pull/8673#discussion_r1348395371
##########
core/src/main/java/org/apache/iceberg/V2Metadata.java:
##########
@@ -39,7 +39,7 @@ private V2Metadata() {}
ManifestFile.MANIFEST_CONTENT.asRequired(),
ManifestFile.SEQUENCE_NUMBER.asRequired(),
ManifestFile.MIN_SEQUENCE_NUMBER.asRequired(),
- ManifestFile.SNAPSHOT_ID.asRequired(),
+ ManifestFile.SNAPSHOT_ID,
Review Comment:
Yes this is the case, but since the `ManifestFile.SNAPSHOT_ID` is already
required:
https://github.com/apache/iceberg/pull/8673/files#diff-063af8055f56892097a498f7de319845da2e0d328f8241a5fc1b88a0822ac08fL51-L52
There is no need to mark it as required again. With the change in this PR,
it is required for both V1 and V2, we don't need to mark it required anymore
when constructing the individual schemas for V1 and V2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
