Re: [PR] Core: Mark `503: added_snapshot_id` as required [iceberg]

[via GitHub]

Fokko commented on code in PR #8673:
URL: https://github.com/apache/iceberg/pull/8673#discussion_r1348436509


##########
core/src/main/java/org/apache/iceberg/GenericManifestFile.java:
##########
@@ -84,15 +84,24 @@ public GenericManifestFile(Schema avroSchema) {
     }
   }
 
+  /**
+   * @deprecated since 1.5.0, will be removed in 1.6.0. Use {@link
+   *     GenericManifestFile#GenericManifestFile(InputFile, int, Long)} with a 
snapshot-id
+   */
+  @Deprecated
   GenericManifestFile(InputFile file, int specId) {
+    this(file, specId, null);
+  }
+
+  GenericManifestFile(InputFile file, int specId, Long snapshotId) {

Review Comment:
   This change was required otherwise we'll end up writing a null for the 
`added_snapshot_id`. 
   
   This method is only used in cases for V1. Mostly in the test folder (as the 
PR shows), but also when there is no manifest-list, and it directly points to 
the manifest:
   
   
![image](https://github.com/apache/iceberg/assets/1134248/a5cb7aec-6536-43e7-9b5c-57b4e478b8db)
   
   I've reverted this change, and used the `copyOf` instead. LMKWYT
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org