kevinjqliu commented on PR #1433:
URL: https://github.com/apache/iceberg-python/pull/1433#issuecomment-2580965961
Thanks for your help improving the docs @jeppe-dos!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
kevinjqliu merged PR #1433:
URL: https://github.com/apache/iceberg-python/pull/1433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@i
kevinjqliu commented on code in PR #1433:
URL: https://github.com/apache/iceberg-python/pull/1433#discussion_r1909250917
##
mkdocs/docs/api.md:
##
@@ -951,8 +951,12 @@ Using `add_column` you can add a column, without having to
worry about the field
with table.update_schema() a
jeppe-dos commented on code in PR #1433:
URL: https://github.com/apache/iceberg-python/pull/1433#discussion_r1906906831
##
mkdocs/docs/api.md:
##
@@ -961,20 +963,21 @@ Renaming a field in an Iceberg table is simple:
```python
with table.update_schema() as update:
update.r
kevinjqliu commented on code in PR #1433:
URL: https://github.com/apache/iceberg-python/pull/1433#discussion_r1906457621
##
mkdocs/docs/api.md:
##
@@ -961,20 +963,21 @@ Renaming a field in an Iceberg table is simple:
```python
with table.update_schema() as update:
update.
kevinjqliu commented on code in PR #1433:
URL: https://github.com/apache/iceberg-python/pull/1433#discussion_r1906456170
##
mkdocs/docs/api.md:
##
@@ -961,20 +963,21 @@ Renaming a field in an Iceberg table is simple:
```python
with table.update_schema() as update:
update.
kevinjqliu commented on code in PR #1433:
URL: https://github.com/apache/iceberg-python/pull/1433#discussion_r1906456170
##
mkdocs/docs/api.md:
##
@@ -961,20 +963,21 @@ Renaming a field in an Iceberg table is simple:
```python
with table.update_schema() as update:
update.
kevinjqliu commented on code in PR #1433:
URL: https://github.com/apache/iceberg-python/pull/1433#discussion_r1905685734
##
mkdocs/docs/api.md:
##
@@ -951,8 +951,10 @@ Using `add_column` you can add a column, without having to
worry about the field
with table.update_schema() a
jeppe-dos closed pull request #1433: Change dot notation in add column
documentation to tuple
URL: https://github.com/apache/iceberg-python/pull/1433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kevinjqliu commented on code in PR #1433:
URL: https://github.com/apache/iceberg-python/pull/1433#discussion_r1904467272
##
mkdocs/docs/api.md:
##
@@ -951,8 +951,10 @@ Using `add_column` you can add a column, without having to
worry about the field
with table.update_schema() a
jeppe-dos commented on PR #1433:
URL: https://github.com/apache/iceberg-python/pull/1433#issuecomment-2573564249
> im having trouble running the new statements in the docs, could you give
it a try ?
The code doesn't work, as "confirmed_by" has been changed to "exchange".
Exchange can
kevinjqliu commented on PR #1433:
URL: https://github.com/apache/iceberg-python/pull/1433#issuecomment-2573362375
im having trouble running the new statements in the docs, could you give it
a try ?
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
kevinjqliu commented on PR #1433:
URL: https://github.com/apache/iceberg-python/pull/1433#issuecomment-2573349822
@jeppe-dos that would be great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jeppe-dos commented on PR #1433:
URL: https://github.com/apache/iceberg-python/pull/1433#issuecomment-2573343676
> that works, but i think the first example should work too. We can track
this in a separate issue.
>
> ```
> >>> with table.update_schema() as update:
> ... upda
kevinjqliu commented on code in PR #1433:
URL: https://github.com/apache/iceberg-python/pull/1433#discussion_r1904282046
##
mkdocs/docs/api.md:
##
@@ -961,20 +963,21 @@ Renaming a field in an Iceberg table is simple:
```python
with table.update_schema() as update:
update.
kevinjqliu commented on code in PR #1433:
URL: https://github.com/apache/iceberg-python/pull/1433#discussion_r1904280959
##
mkdocs/docs/api.md:
##
@@ -961,20 +963,21 @@ Renaming a field in an Iceberg table is simple:
```python
with table.update_schema() as update:
update.
kevinjqliu commented on code in PR #1433:
URL: https://github.com/apache/iceberg-python/pull/1433#discussion_r1904280648
##
mkdocs/docs/api.md:
##
@@ -1006,6 +1009,8 @@ Delete a field, careful this is a incompatible change
(readers/writers might exp
```python
with table.updat
kevinjqliu commented on PR #1433:
URL: https://github.com/apache/iceberg-python/pull/1433#issuecomment-2573325406
that works, but i think the first example should work too. We can track this
in a separate issue.
```
>>> with table.update_schema() as update:
... update.a
jeppe-dos commented on PR #1433:
URL: https://github.com/apache/iceberg-python/pull/1433#issuecomment-2573318869
What if you create the struct first, and then add the nested field like so:
```
with table.update_schema() as update:
update.add_column("retries", IntegerType(),
jeppe-dos commented on PR #1433:
URL: https://github.com/apache/iceberg-python/pull/1433#issuecomment-2572871762
The struct is now created first in the add column section. I have also
changed from dot to tuple in move and rename column.
--
This is an automated message from the Apache Git
jeppe-dos commented on PR #1433:
URL: https://github.com/apache/iceberg-python/pull/1433#issuecomment-2572756873
I assume so. I'll test and update accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
kevinjqliu commented on PR #1433:
URL: https://github.com/apache/iceberg-python/pull/1433#issuecomment-2557283437
i found another dot notion in `Move column`, do we need to change this too?
https://py.iceberg.apache.org/api/#move-column
--
This is an automated message from the Apache Gi
kevinjqliu commented on PR #1433:
URL: https://github.com/apache/iceberg-python/pull/1433#issuecomment-2557282080
> Yes, the struct has to exist before you can insert anything into it.
ah i see, that makes sense. in that case, can we edit the example so that it
works out of the box?
jeppe-dos commented on PR #1433:
URL: https://github.com/apache/iceberg-python/pull/1433#issuecomment-2557064966
> Looks like there might be a bug with this change. I tried to follow the
docs
>
> ```
> from pyiceberg.catalog.sql import SqlCatalog
> from pyiceberg.schema import S
kevinjqliu commented on PR #1433:
URL: https://github.com/apache/iceberg-python/pull/1433#issuecomment-2549215540
Heres where the errors happens
https://github.com/apache/iceberg-python/blob/b0ea716c91f19281d3d9cd7b6965d5d01f6cc3d5/pyiceberg/table/update/schema.py#L184-L192
And
jeppe-dos opened a new pull request, #1433:
URL: https://github.com/apache/iceberg-python/pull/1433
A tuple must be used to make columns in structs as described in add_column:
"Because "." may be interpreted as a column path separator or may be used in
field names, it is not allowed to a
26 matches
Mail list logo
