kevinjqliu commented on code in PR #1433:
URL: https://github.com/apache/iceberg-python/pull/1433#discussion_r1905685734
##########
mkdocs/docs/api.md:
##########
@@ -951,8 +951,10 @@ Using `add_column` you can add a column, without having to
worry about the field
with table.update_schema() as update:
update.add_column("retries", IntegerType(), "Number of retries to place
the bid")
# In a struct
- update.add_column("details.confirmed_by", StringType(), "Name of the
exchange")
+ update.add_column("details", StructType())
+ update.add_column(("details", "confirmed_by"), StringType(), "Name of the
exchange")
Review Comment:
```suggestion
with table.update_schema() as update:
update.add_column(("details", "confirmed_by"), StringType(), "Name
of the exchange")
```
https://github.com/apache/iceberg-python/pull/1433#issuecomment-2573318869
I opened https://github.com/apache/iceberg-python/issues/1493 to track this
issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
