jeppe-dos commented on PR #1433: URL: https://github.com/apache/iceberg-python/pull/1433#issuecomment-2573343676
> that works, but i think the first example should work too. We can track this in a separate issue. > > ``` > >>> with table.update_schema() as update: > ... update.add_column("retries", IntegerType(), "Number of retries to place the bid") > ... # In a struct > ... update.add_column("details", StructType()) > ... > <pyiceberg.table.update.schema.UpdateSchema object at 0x11fc59880> > <pyiceberg.table.update.schema.UpdateSchema object at 0x11fc59880> > >>> with table.update_schema() as update: > ... update.add_column(("details", "confirmed_by"), StringType(), "Name of the exchange") > ... > <pyiceberg.table.update.schema.UpdateSchema object at 0x1189d9370> > >>> print(table.refresh().schema()) > table { > 1: city: optional string > 2: lat: optional double > 3: long: optional double > 4: retries: optional int (Number of retries to place the bid) > 5: details: optional struct<6: confirmed_by: optional string (Name of the exchange)> > } > ``` Agreed. Thank you for reviewing the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org