kevinjqliu commented on code in PR #1433:
URL: https://github.com/apache/iceberg-python/pull/1433#discussion_r1909250917


##########
mkdocs/docs/api.md:
##########
@@ -951,8 +951,12 @@ Using `add_column` you can add a column, without having to 
worry about the field
 with table.update_schema() as update:
     update.add_column("retries", IntegerType(), "Number of retries to place 
the bid")
     # In a struct
-    update.add_column("details.confirmed_by", StringType(), "Name of the 
exchange")
+    update.add_column("details", StructType())
+
+    with table.update_schema() as update:
+        update.add_column(("details", "confirmed_by"), StringType(), "Name of 
the exchange")

Review Comment:
   ```suggestion
   with table.update_schema() as update:
       update.add_column(("details", "confirmed_by"), StringType(), "Name of 
the exchange")
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to