lidavidm closed pull request #45: Build/link to Rust iceberg-c library
URL: https://github.com/apache/iceberg-cpp/pull/45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
lidavidm commented on PR #45:
URL: https://github.com/apache/iceberg-cpp/pull/45#issuecomment-2731928970
For sure, I just wanted to prove that the CMake work I did on the other side
works properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
Xuanwo commented on PR #45:
URL: https://github.com/apache/iceberg-cpp/pull/45#issuecomment-2731923580
Hi, @lidavidm, maybe we should link against the iceberg-rust cpp bindings?
I'll prepare another PR to demonstrate how CXX works.
--
This is an automated message from the Apache Git Serv
lidavidm opened a new pull request, #45:
URL: https://github.com/apache/iceberg-cpp/pull/45
Requires https://github.com/apache/iceberg-rust/pull/966 with changes from
https://github.com/lidavidm/iceberg-rust/tree/add-c-binding.
--
This is an automated message from the Apache Git Service.
wgtmac commented on code in PR #45:
URL: https://github.com/apache/iceberg-cpp/pull/45#discussion_r2000392422
##
src/iceberg/CMakeLists.txt:
##
@@ -21,7 +21,11 @@ add_iceberg_lib(iceberg
SOURCES
${ICEBERG_SOURCES}
PRIVATE_INCLUD
lidavidm commented on code in PR #45:
URL: https://github.com/apache/iceberg-cpp/pull/45#discussion_r2000362489
##
src/iceberg/CMakeLists.txt:
##
@@ -21,7 +21,11 @@ add_iceberg_lib(iceberg
SOURCES
${ICEBERG_SOURCES}
PRIVATE_INCL
wgtmac commented on code in PR #45:
URL: https://github.com/apache/iceberg-cpp/pull/45#discussion_r2000361040
##
src/iceberg/CMakeLists.txt:
##
@@ -21,7 +21,11 @@ add_iceberg_lib(iceberg
SOURCES
${ICEBERG_SOURCES}
PRIVATE_INCLUD
