wgtmac commented on code in PR #45:
URL: https://github.com/apache/iceberg-cpp/pull/45#discussion_r2000361040
##########
src/iceberg/CMakeLists.txt:
##########
@@ -21,7 +21,11 @@ add_iceberg_lib(iceberg
SOURCES
${ICEBERG_SOURCES}
PRIVATE_INCLUDES
- ${ICEBERG_INCLUDES})
+ ${ICEBERG_INCLUDES}
+ SHARED_LINK_LIBS
+ IcebergC::iceberg_c_shared
Review Comment:
Do we need to make `iceberg` library mainly interface-oriented and add a new
`iceberg-rust-cxx-binding` library to plug in the implementation? It is still
unclear to me the extent of plug-ability in this approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
