lidavidm commented on code in PR #45:
URL: https://github.com/apache/iceberg-cpp/pull/45#discussion_r2000362489
##########
src/iceberg/CMakeLists.txt:
##########
@@ -21,7 +21,11 @@ add_iceberg_lib(iceberg
SOURCES
${ICEBERG_SOURCES}
PRIVATE_INCLUDES
- ${ICEBERG_INCLUDES})
+ ${ICEBERG_INCLUDES}
+ SHARED_LINK_LIBS
+ IcebergC::iceberg_c_shared
Review Comment:
It depends on if we want to use Rust definitions for things like data types
too, or if we just want to use it to implement talking to catalogs etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
