wgtmac commented on code in PR #45:
URL: https://github.com/apache/iceberg-cpp/pull/45#discussion_r2000392422
##########
src/iceberg/CMakeLists.txt:
##########
@@ -21,7 +21,11 @@ add_iceberg_lib(iceberg
SOURCES
${ICEBERG_SOURCES}
PRIVATE_INCLUDES
- ${ICEBERG_INCLUDES})
+ ${ICEBERG_INCLUDES}
+ SHARED_LINK_LIBS
+ IcebergC::iceberg_c_shared
Review Comment:
I think that leveraging rust library is a good approach to move fast.
However, there are still users that don't have a rust toolchain, or do not want
to add extra dependencies introduced by the rust library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
