Re: [PR] Avro: Add internal writer [iceberg]

rdblue merged PR #11919: URL: https://github.com/apache/iceberg/pull/11919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Avro: Add internal writer [iceberg]

rdblue commented on PR #11919: URL: https://github.com/apache/iceberg/pull/11919#issuecomment-2583543250 Would have been nice to fix the nit from the last review, but it isn't a blocker. Thanks, @ajantha-bhat! I'll merge. -- This is an automated message from the Apache Git Service.

Re: [PR] Avro: Add internal writer [iceberg]

ajantha-bhat commented on PR #11919: URL: https://github.com/apache/iceberg/pull/11919#issuecomment-2581584910 Rebased as I hit the flaky test https://github.com/apache/iceberg/issues/11833 -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] Avro: Add internal writer [iceberg]

ajantha-bhat commented on code in PR #11919: URL: https://github.com/apache/iceberg/pull/11919#discussion_r1909649535 ## core/src/test/java/org/apache/iceberg/avro/TestInternalAvro.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] Avro: Add internal writer [iceberg]

rdblue commented on code in PR #11919: URL: https://github.com/apache/iceberg/pull/11919#discussion_r1909249879 ## core/src/test/java/org/apache/iceberg/avro/TestInternalAvro.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Avro: Add internal writer [iceberg]

rdblue commented on code in PR #11919: URL: https://github.com/apache/iceberg/pull/11919#discussion_r1909246082 ## api/src/test/java/org/apache/iceberg/util/RandomUtil.java: ## @@ -228,4 +235,54 @@ private static BigInteger randomUnscaled(int precision, Random random) {

Re: [PR] Avro: Add internal writer [iceberg]

ajantha-bhat commented on code in PR #11919: URL: https://github.com/apache/iceberg/pull/11919#discussion_r1908005218 ## core/src/test/java/org/apache/iceberg/avro/AvroTestHelpers.java: ## @@ -126,9 +139,18 @@ private static void assertEquals(Type type, Object expected, Object

Re: [PR] Avro: Add internal writer [iceberg]

rdblue commented on code in PR #11919: URL: https://github.com/apache/iceberg/pull/11919#discussion_r1907595448 ## core/src/test/java/org/apache/iceberg/avro/AvroTestHelpers.java: ## @@ -126,9 +139,18 @@ private static void assertEquals(Type type, Object expected, Object actual

Re: [PR] Avro: Add internal writer [iceberg]

rdblue commented on code in PR #11919: URL: https://github.com/apache/iceberg/pull/11919#discussion_r1907589600 ## core/src/test/java/org/apache/iceberg/avro/AvroTestHelpers.java: ## @@ -126,9 +139,18 @@ private static void assertEquals(Type type, Object expected, Object actual

Re: [PR] Avro: Add internal writer [iceberg]

rdblue commented on code in PR #11919: URL: https://github.com/apache/iceberg/pull/11919#discussion_r1907587135 ## core/src/test/java/org/apache/iceberg/avro/AvroTestHelpers.java: ## @@ -78,6 +79,18 @@ static void assertEquals(Types.StructType struct, Record expected, Record ac

Re: [PR] Avro: Add internal writer [iceberg]

rdblue commented on code in PR #11919: URL: https://github.com/apache/iceberg/pull/11919#discussion_r1907584770 ## core/src/test/java/org/apache/iceberg/avro/TestInternalAvro.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Avro: Add internal writer [iceberg]

rdblue commented on code in PR #11919: URL: https://github.com/apache/iceberg/pull/11919#discussion_r1907583554 ## core/src/test/java/org/apache/iceberg/avro/RandomAvroData.java: ## @@ -51,6 +53,66 @@ public static List generate(Schema schema, int numRecords, long seed) {

Re: [PR] Avro: Add internal writer [iceberg]

ajantha-bhat commented on PR #11919: URL: https://github.com/apache/iceberg/pull/11919#issuecomment-2577847304 @rdblue: Thanks a lot for the review. I have addressed all the comments. PR is ready. -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] Avro: Add internal writer [iceberg]

rdblue commented on code in PR #11919: URL: https://github.com/apache/iceberg/pull/11919#discussion_r1905995521 ## core/src/test/java/org/apache/iceberg/avro/TestInternalWriter.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Avro: Add internal writer [iceberg]

rdblue commented on code in PR #11919: URL: https://github.com/apache/iceberg/pull/11919#discussion_r1905993934 ## core/src/test/java/org/apache/iceberg/avro/TestInternalWriter.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Avro: Add internal writer [iceberg]

rdblue commented on code in PR #11919: URL: https://github.com/apache/iceberg/pull/11919#discussion_r1905993243 ## core/src/test/java/org/apache/iceberg/avro/TestInternalWriter.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Avro: Add internal writer [iceberg]

rdblue commented on code in PR #11919: URL: https://github.com/apache/iceberg/pull/11919#discussion_r1905992426 ## core/src/test/java/org/apache/iceberg/avro/TestInternalWriter.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Avro: Add internal writer [iceberg]

rdblue commented on code in PR #11919: URL: https://github.com/apache/iceberg/pull/11919#discussion_r1905991506 ## core/src/test/java/org/apache/iceberg/avro/TestInternalWriter.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Avro: Add internal writer [iceberg]

rdblue commented on code in PR #11919: URL: https://github.com/apache/iceberg/pull/11919#discussion_r1905990532 ## core/src/test/java/org/apache/iceberg/avro/TestInternalWriter.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Avro: Add internal writer [iceberg]

rdblue commented on code in PR #11919: URL: https://github.com/apache/iceberg/pull/11919#discussion_r1905975033 ## core/src/main/java/org/apache/iceberg/avro/InternalWriter.java: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c

Re: [PR] Avro: Add internal writer [iceberg]

rdblue commented on code in PR #11919: URL: https://github.com/apache/iceberg/pull/11919#discussion_r1905968427 ## core/src/main/java/org/apache/iceberg/avro/ValueWriters.java: ## @@ -484,4 +489,16 @@ protected Object get(IndexedRecord struct, int pos) { return struct.get

Re: [PR] Avro: Add internal writer [iceberg]

rdblue commented on code in PR #11919: URL: https://github.com/apache/iceberg/pull/11919#discussion_r1905964811 ## core/src/main/java/org/apache/iceberg/avro/InternalWriter.java: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c

Re: [PR] Avro: Add internal writer [iceberg]

rdblue commented on code in PR #11919: URL: https://github.com/apache/iceberg/pull/11919#discussion_r1905964811 ## core/src/main/java/org/apache/iceberg/avro/InternalWriter.java: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c

Re: [PR] Avro: Add internal writer [iceberg]

rdblue commented on code in PR #11919: URL: https://github.com/apache/iceberg/pull/11919#discussion_r1905950940 ## core/src/main/java/org/apache/iceberg/avro/InternalReader.java: ## @@ -205,7 +205,6 @@ public ValueReader primitive(Pair partner, Schema primitive) { case

Re: [PR] Avro: Add internal writer [iceberg]

rdblue commented on code in PR #11919: URL: https://github.com/apache/iceberg/pull/11919#discussion_r1905943594 ## core/src/main/java/org/apache/iceberg/avro/BaseAvroSchemaVisitor.java: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] Avro: Add internal writer [iceberg]

rdblue commented on code in PR #11919: URL: https://github.com/apache/iceberg/pull/11919#discussion_r1905843540 ## core/src/main/java/org/apache/iceberg/avro/BaseAvroSchemaVisitor.java: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] Avro: Add internal writer [iceberg]

rdblue commented on code in PR #11919: URL: https://github.com/apache/iceberg/pull/11919#discussion_r1905843540 ## core/src/main/java/org/apache/iceberg/avro/BaseAvroSchemaVisitor.java: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] Avro: Add internal writer [iceberg]

ajantha-bhat commented on code in PR #11919: URL: https://github.com/apache/iceberg/pull/11919#discussion_r1904025164 ## core/src/test/java/org/apache/iceberg/avro/TestInternalWriter.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Avro: Add internal writer [iceberg]

ajantha-bhat commented on code in PR #11919: URL: https://github.com/apache/iceberg/pull/11919#discussion_r1904018273 ## core/src/main/java/org/apache/iceberg/avro/InternalReader.java: ## @@ -205,7 +205,6 @@ public ValueReader primitive(Pair partner, Schema primitive) {

Re: [PR] Avro: Add internal writer [iceberg]

ajantha-bhat commented on code in PR #11919: URL: https://github.com/apache/iceberg/pull/11919#discussion_r1904018273 ## core/src/main/java/org/apache/iceberg/avro/InternalReader.java: ## @@ -205,7 +205,6 @@ public ValueReader primitive(Pair partner, Schema primitive) {

[PR] Avro: Add internal writer [iceberg]

ajantha-bhat opened a new pull request, #11919: URL: https://github.com/apache/iceberg/pull/11919 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib