rdblue commented on code in PR #11919: URL: https://github.com/apache/iceberg/pull/11919#discussion_r1905950940
########## core/src/main/java/org/apache/iceberg/avro/InternalReader.java: ########## @@ -205,7 +205,6 @@ public ValueReader<?> primitive(Pair<Integer, Type> partner, Schema primitive) { case STRING: return ValueReaders.strings(); case FIXED: Review Comment: I agree with this change. Another check that this is correct is that `ByteBuffer` is used as the representation used by `FixedLiteral`, which must match the type of internal objects. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org