rdblue commented on code in PR #11919:
URL: https://github.com/apache/iceberg/pull/11919#discussion_r1907583554
##########
core/src/test/java/org/apache/iceberg/avro/RandomAvroData.java:
##########
@@ -51,6 +53,66 @@ public static List<Record> generate(Schema schema, int
numRecords, long seed) {
return records;
}
+ public static List<StructLike> generateStructLike(Schema schema, int
numRecords, long seed) {
Review Comment:
I don't think it makes sense for this utility to generate data for the
internal object model. It's named `RandomAvroData` and generates the Avro
object model. I would expect the utility to generate internal data to be in
`RandomInternalData`.
Also, the `generateList` and `generateMap` methods can be either moved to
`RandomUtil` or just duplicated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
